Update to allow postrun to only run after a successful HealthCheck #5330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three changes: - postrun removed from run on init to run exactly once after HealthCheck is OK - re-run postrun after each service Start - changed self.health_check so it gets assigned (it didn't before) This does somewhat change the behaviour of postrun, which used to only run at init - this part can be backed out if needed.
jamessewell
requested review from
baumanj,
christophermaier,
fnichol and
reset
as code owners
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
|
Did you mean to close this, @jamessewell ? |
|
Oh, I see. You opened #5331 instead. I'll try to look at that today or tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three changes:
This does somewhat change the behaviour of postrun, which used to only
run at init - this part can be backed out if needed.