Some code cleanups after #5866 #6077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesc
requested review from
baumanj,
christophermaier,
eeyun,
fnichol,
raskchanky and
reset
as code owners
mwrock
reviewed
Jan 24, 2019
mwrock
approved these changes
Jan 24, 2019
christophermaier
approved these changes
Jan 24, 2019
* Remove some unused imports * Removed accidentally checked in file * Use a TESTING_FS_ROOT for cargo tests so we don't write into /hab Signed-off-by: James Casey <james@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some misc cleanups after #5866 was merged
TESTING_FS_ROOTset. This stops the tests writing to/hab/svc/testduring a unit test run (or failing if there is no permission to write there)