New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to implement template debugging tool #6114

Merged

baumanj merged 39 commits into habitat-sh:master from qubitrenegade:qbr/add-plan-render-command

Mar 13, 2019

Contributor

qubitrenegade commented Feb 3, 2019 •

edited

Loading

This pull request is related to #5065 ~~and is currently in progress.~~

~~Please refer to #5065 for discussion.~~

qubitrenegade requested review from baumanj, chefsalim, christophermaier, eeyun, fnichol, jamesc, raskchanky and reset as code owners

February 3, 2019 01:40

Contributor

thesentinels commented Feb 3, 2019

Thanks for the pull request! Here is what will happen next:

Your PR will be reviewed by the maintainers
If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

qubitrenegade mentioned this pull request

Template debugging tool #5065

Closed

qubitrenegade force-pushed the qbr/add-plan-render-command branch 14 times, most recently from 24c9650 to 72d9ce5 Compare

February 3, 2019 12:03

Contributor

baumanj commented Feb 4, 2019

Thanks so much for working on this! I'm probably not going to have bandwidth to give a proper review for a couple days at least, but I'll definitely take a look when I can.

Contributor

christophermaier commented Feb 4, 2019

This is also in my queue to review... looking forward to taking a look!

Contributor

baumanj commented Feb 7, 2019

We haven't forgotten about you, but since I'm out tomorrow, I just wanted to let you know that Monday is the earliest I'll be able to start reviewing this. Thanks for your patience!

dmccown assigned christophermaier and baumanj

Contributor

christophermaier commented Feb 12, 2019

I'm in the middle of reviewing this now, FYI.

qubitrenegade added 16 commits

March 9, 2019 12:37


          no_render_dir to no_render

aeece66

Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>


          rustfmt fueled cleanup

ec8cb3a


          use @baumanj method of merging json structs.

a4886f1

Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>


          rebase master. add back the unwrap for now... does #TODO: fix using '…

9a5f35f

….unwrap()' work?

Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>


          Add inspec file for consul_config.json

a159501

Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>


          return Result<Json> instead of Json

bff2b63


          First pass at adding Error type for serde_json::Error

c960a88

Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>


          Remove unwrap() and .expect(); propagate errors. Add broken test toml…

ff0e44f

…/json files.

Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>


          re-revert changes to support/linux/install_dev_9_linux.sh

60339a3

Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>


          apply shellcheck-and-rustfmt-fixes.patch.txt

6508e13

Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>


          Fix use of no_render_dir

f7e7be7

Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>


          simplify parsing *_path variables

3b08980

Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>


          !(quiet) to !quiet

e7c43c5

Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>


          {:?} to {}

e1f94c9

Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>


          simplify getting file_name

874bee5

Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>


          add broken template to test/fixtues and test/fixtures/render/error di…

cbaa742

…rectory to shellcheck exclude

qubitrenegade force-pushed the qbr/add-plan-render-command branch from fe4ec09 to 87467d8 Compare

March 9, 2019 19:38


          rustfmt cleanup

0f3c654

Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>

qubitrenegade force-pushed the qbr/add-plan-render-command branch from 87467d8 to 0f3c654 Compare

March 9, 2019 19:48

Contributor Author

qubitrenegade commented Mar 9, 2019

Alright, I think that's everything.

I think renaming NO_WRITE_FILE to NO_RENDER, then when parsing it let render = !m.is_present("NO_RENDER"); is the most elegant solution? re: not no render.


          NO_WRITE_FILE to NO_RENDER

e3e7666

Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>

baumanj added the X-feature label

baumanj approved these changes

View reviewed changes

baumanj merged commit 259c934 into habitat-sh:master

chef-ci added a commit that referenced this pull request


          Update CHANGELOG.md with details from pull request #6114

8cac6f3

Obvious fix; these changes are the result of automation not creative thinking.

qubitrenegade deleted the qbr/add-plan-render-command branch

March 14, 2019 04:12

Contributor Author

qubitrenegade commented Mar 14, 2019 •

edited

Loading

w00t! And added to the change log!

This is awesome 🎉

Thanks for all the help along the way too! I learned a ton! (as to how much I retain...)

Github is dumb sometimes, was trying to respond inline but doesn't seem to be an option anymore...

re unwrap() convo: I think that makes sense. unwrap() is an "unsafe" operation, so we try to avoid it where we can because the compiler can't ensure safety (hence the panic); we can reason about how our code is unreachable so an unwrap() is safe because there's no way an "unsafe" value could be passed?

Really, thanks for all the back and forth. It really has been educational. (and an overall great experience! :) )

This is so cool! 😀

baumanj mentioned this pull request

Handlebars template previewer #1137

Closed

christophermaier added Type:Feature and removed X-feature labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

christophermaier christophermaier left review comments

baumanj baumanj approved these changes

chefsalim Awaiting requested review from chefsalim

eeyun Awaiting requested review from eeyun

fnichol Awaiting requested review from fnichol

jamesc Awaiting requested review from jamesc

raskchanky Awaiting requested review from raskchanky

reset Awaiting requested review from reset

Labels