Skip to content

Commit

Permalink
Codecov failing due to lack of token (#443)
Browse files Browse the repository at this point in the history
* Update codecov-action to version 4
* Update gregsdennis/dependencies-action to 1.3.3
  • Loading branch information
alfonsorr committed Apr 23, 2024
1 parent 6bc9971 commit 73aa00d
Show file tree
Hide file tree
Showing 5 changed files with 78 additions and 83 deletions.
76 changes: 0 additions & 76 deletions .github/actions/build_and_coverage/action.yml

This file was deleted.

4 changes: 2 additions & 2 deletions .github/codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ codecov:
branch: main
notify:
wait_for_ci: true
after_n_builds: 4
after_n_builds: 5

coverage:
precision: 2
Expand Down Expand Up @@ -37,4 +37,4 @@ comment:
layout: "reach,diff,flags,files,footer"
behavior: once # once: update, if exists. Otherwise, post new. Skip if deleted.
require_changes: false # if true: only post the comment if coverage changes
after_n_builds: 4
after_n_builds: 5
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
name: Check Dependencies
steps:
- name: PR Dependency Check
uses: gregsdennis/dependencies-action@1.3.2
uses: gregsdennis/dependencies-action@1.3.3
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expand Down Expand Up @@ -64,6 +64,7 @@ jobs:
uses: ./.github/workflows/wc_build.yml
with:
matrix_filter: "[]"
secrets: inherit

# CHECK MDOC IS OK
check_mdoc:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
uses: ./.github/workflows/wc_build.yml
with:
matrix_filter: "[?isRelease==`release`]"
secrets: inherit

# PUBLISH JARS AT MAVEN CENTRAL
matrix_prep:
Expand Down
77 changes: 73 additions & 4 deletions .github/workflows/wc_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:
matrix_filter:
required: true
type: string
secrets:
CODECOV_TOKEN:
required: true

jobs:
matrix_prep:
Expand All @@ -29,7 +32,73 @@ jobs:
steps:
- uses: actions/checkout@v4

- uses: ./.github/actions/build_and_coverage
env:
SPARK_VERSION: ${{ matrix.spark }}
SCOPE: ${{ matrix.scope }}
# SETUP & CACHE
- uses: coursier/setup-action@v1.3.0
with:
jvm: adopt:8
apps: sbt scala scalafmt # https://github.com/coursier/apps

- uses: coursier/cache-action@v6
with:
extraKey: "${{ matrix.spark }}"

# CHECK CODE FORMAT
- name: Code Format
id: code_format
if: contains(matrix.scope, 'test')
run: sbt -DsparkVersion=${{ matrix.spark }} scalafmtCheckAll
shell: bash

# TESTING & COVERAGE
- name: Test & coverage 📋
id: test_coverage
if: steps.code_format.conclusion == 'success'
run: sbt -DsparkVersion=${{ matrix.spark }} coverage +core/test coverageAggregate
shell: bash

- name: Test Summary
id: test_summary
if: ${{ success() && steps.test_coverage.conclusion == 'success' || failure() && steps.test_coverage.conclusion == 'failure' }}
uses: test-summary/action@v2.0
with:
paths: "./core/target/test-reports/**/TEST-*.xml"
output: "test-summary.md"

- name: Add 2 GitHub step summary
if: ${{ (success() || failure()) && steps.test_summary.conclusion == 'success' }}
shell: bash
run: cat test-summary.md >> $GITHUB_STEP_SUMMARY

- name: Add summary link
id: add_summary_link
if: ${{ (success() || failure()) && steps.test_summary.conclusion == 'success' }}
shell: bash
run: |
img=$(head -1 test-summary.md | perl -pe 's/(<.*?.>).*/$1/')
url="${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
echo "| ${{ matrix.spark }} | [${img}](${url}) |" > test-summary-${{ matrix.spark }}.md
cat -e test-summary-${{ matrix.spark }}.md
- name: Upload test summary
if: ${{ github.event_name == 'pull_request' && ((success() || failure()) && steps.add_summary_link.conclusion == 'success') }}
uses: actions/upload-artifact@v3
with:
name: "test-summary-${{ matrix.spark }}.md"
path: "test-summary-${{ matrix.spark }}.md"
if-no-files-found: error
retention-days: 1

- name: Publish coverage to codecov 📊
if: contains(matrix.scope, 'uploadReport')
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: ./target/scala-2.12/scoverage-report/scoverage.xml,./target/scala-2.13/scoverage-report/scoverage.xml
fail_ci_if_error: true
verbose: false
flags: 'spark-${{ matrix.spark }}.x'

# CLEAN PROJECT BEFORE CACHE
- name: Cleaning before cache 🚯
if: ${{ always() }}
uses: ./.github/actions/clean_cache

0 comments on commit 73aa00d

Please sign in to comment.