Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/#60 implemented aggregate functions #123

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Feat/#60 implemented aggregate functions #123

merged 1 commit into from
Dec 23, 2021

Conversation

eruizalo
Copy link
Collaborator

@eruizalo eruizalo commented Dec 14, 2021 •
edited
Loading

@eruizalo eruizalo mentioned this pull request Dec 14, 2021
Closed
28 tasks
@eruizalo eruizalo added the enhancement New feature or request label Dec 14, 2021
@eruizalo eruizalo marked this pull request as draft December 14, 2021 17:03
@codecov
Copy link

codecov bot commented Dec 14, 2021 •
edited
Loading

Codecov Report

Merging #123 (0ecba17) into main (50e7a9b) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   91.44%   91.63%   +0.18%     
==========================================
  Files          39       39              
  Lines         596      609      +13     
  Branches       10        9       -1     
==========================================
+ Hits          545      558      +13     
  Misses         51       51
Impacted Files Coverage Δ
core/src/main/scala/doric/doric.scala 90.91% <ø> (ø)
...c/main/scala/doric/syntax/AggregationColumns.scala 100.00% <100.00%> (ø)
core/src/main/scala/doric/types/SparkType.scala 91.67% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50e7a9b...0ecba17. Read the comment docs.

@eruizalo eruizalo force-pushed the feat/60-implemented-aggregate-functions branch 2 times, most recently from 3695e1e to 48f61b8 Compare December 23, 2021 11:39
@eruizalo
feat: add aggregate functions (resolves hablapps#60)
0ecba17 
- Resolves hablapps#60
- Add `ByteType` & `Byte Column`
- Add `testGrouped` method for `RelationalGroupedDataset` testing
@eruizalo eruizalo force-pushed the feat/60-implemented-aggregate-functions branch from 48f61b8 to 0ecba17 Compare December 23, 2021 16:49
@eruizalo eruizalo marked this pull request as ready for review December 23, 2021 16:50
@eruizalo eruizalo merged commit 28edbb3 into hablapps:main Dec 23, 2021
@eruizalo eruizalo deleted the feat/60-implemented-aggregate-functions branch December 23, 2021 16:59
@eruizalo eruizalo added this to the V1 milestone Dec 27, 2021
@eruizalo eruizalo mentioned this pull request Jun 24, 2022
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsorr alfonsorr alfonsorr approved these changes

Assignees

@alfonsorr alfonsorr

Labels
enhancement New feature or request
Projects
None yet
Milestone
V1
Development

Successfully merging this pull request may close these issues.

Implemented Aggregate functions
2 participants
@eruizalo @alfonsorr