Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the use of CName less intrusive #136

Merged
merged 7 commits into from
Jan 11, 2022

Conversation

alfonsorr
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #136 (c7e12ea) into main (1aa7c4d) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   94.84%   94.99%   +0.14%     
==========================================
  Files          41       41              
  Lines         698      698              
  Branches        9        8       -1     
==========================================
+ Hits          662      663       +1     
+ Misses         36       35       -1     
Impacted Files Coverage Δ
core/src/main/scala/doric/DoricJoinColumn.scala 80.00% <ø> (ø)
core/src/main/scala/doric/sem/TransformOps.scala 75.00% <ø> (ø)
core/src/main/scala/doric/syntax/ColGetters.scala 85.00% <ø> (ø)
core/src/main/scala/doric/syntax/TypeMatcher.scala 100.00% <ø> (ø)
core/src/main/scala/doric/CName.scala 100.00% <100.00%> (ø)
core/src/main/scala/doric/DoricColumn.scala 77.14% <100.00%> (ø)
core/src/main/scala/doric/sem/Errors.scala 82.14% <100.00%> (ø)
core/src/main/scala/doric/syntax/CNameOps.scala 100.00% <100.00%> (ø)
...re/src/main/scala/doric/syntax/CommonColumns.scala 100.00% <100.00%> (+5.88%) ⬆️
core/src/main/scala/doric/syntax/DStructs.scala 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aa7c4d...c7e12ea. Read the comment docs.

eruizalo
eruizalo previously approved these changes Jan 10, 2022
eruizalo
eruizalo previously approved these changes Jan 10, 2022
@alfonsorr alfonsorr merged commit 5e8acc3 into hablapps:main Jan 11, 2022
@alfonsorr alfonsorr deleted the fix/cname_simplified branch January 11, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants