-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross build doric from Spark 3.0 to 3.2 #184
Merged
eruizalo
merged 6 commits into
hablapps:main
from
alfonsorr:feature/build_spark_versions
Mar 3, 2022
Merged
Cross build doric from Spark 3.0 to 3.2 #184
eruizalo
merged 6 commits into
hablapps:main
from
alfonsorr:feature/build_spark_versions
Mar 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #184 +/- ##
==========================================
+ Coverage 95.95% 95.97% +0.02%
==========================================
Files 43 48 +5
Lines 790 794 +4
Branches 11 10 -1
==========================================
+ Hits 758 762 +4
Misses 32 32
Continue to review full report at Codecov.
|
Closed
3 tasks
eruizalo
requested changes
Mar 2, 2022
core/src/main/spark_3.2_mount/scala/doric/syntax/BinaryColumns32.scala
Outdated
Show resolved
Hide resolved
Sbt now accepts sparkVersion for full version (x.x.x) and sparkShortVersion (x.x)
eruizalo
approved these changes
Mar 3, 2022
This was referenced Apr 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
spark_3.0
PR changes to spark 3.0
spark_3.1
PR changes to spark 3.1
spark_3.2
PR changes to spark 3.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request allows to pass to sbt sparkVersion parameter to select the spark version from 3.0 to 3.2. Compiling and testing is
Related Issue
#159
Motivation and Context
Allow to use doric with any 3.x version with all the available functionality.
How Has This Been Tested?
Launched for all spark versions