Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [~] codecov reports with flags #196

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

eruizalo
Copy link
Collaborator

Description

Adding flag management for codecov reports

Related Issue

None

Motivation and Context

It doesn't seem right at codecov after adding flags: I couldn't see any flags at main and some files went missing

How Has This Been Tested?

Not tested

  • This pull request contains appropriate tests?

@eruizalo eruizalo added the fix PR fixes label Mar 20, 2022
@eruizalo eruizalo self-assigned this Mar 20, 2022
@eruizalo eruizalo requested a review from a team as a code owner March 20, 2022 16:21
@github-actions github-actions bot added the CI/CD Continuous integration and continuous delivery label Mar 20, 2022
@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #196 (1f42351) into main (bb897a7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files          49       49           
  Lines         798      798           
  Branches        9        9           
=======================================
  Hits          766      766           
  Misses         32       32           
Flag Coverage Δ
3.0.x ?
3.1.x ?
3.2.x ?
spark-3.0.x 94.82% <ø> (?)
spark-3.1.x 95.97% <ø> (?)
spark-3.2.x 95.97% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb897a7...1f42351. Read the comment docs.

@eruizalo eruizalo force-pushed the fix/codecov_reports_with_flags branch from e17693f to c3fa68a Compare March 20, 2022 17:05
@eruizalo eruizalo marked this pull request as draft March 25, 2022 12:30
@eruizalo eruizalo force-pushed the fix/codecov_reports_with_flags branch from c3fa68a to 1f42351 Compare March 28, 2022 09:24
@eruizalo eruizalo marked this pull request as ready for review March 28, 2022 12:24
@alfonsorr alfonsorr merged commit c1c272b into hablapps:main Mar 28, 2022
@eruizalo eruizalo deleted the fix/codecov_reports_with_flags branch March 28, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continuous integration and continuous delivery fix PR fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants