Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [~] str interpolator now prints empty if null column (issue #191) #199

Merged

Conversation

eruizalo
Copy link
Collaborator

Description

Using concat_ws instead of concat we can avoid this error (but we have as limitation that nulls will be skipped)

Related Issue

Resolves #191

How Has This Been Tested?

  • This pull request contains appropriate tests?

@eruizalo eruizalo added the fix PR fixes label Mar 28, 2022
@eruizalo eruizalo self-assigned this Mar 28, 2022
@eruizalo eruizalo requested a review from a team as a code owner March 28, 2022 18:15
@eruizalo eruizalo added spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 labels Mar 28, 2022
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #199 (bea53bd) into main (ae94977) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #199   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files          49       49           
  Lines         798      798           
  Branches        9       11    +2     
=======================================
  Hits          766      766           
  Misses         32       32           
Flag Coverage Δ
spark-3.0.x 94.82% <100.00%> (ø)
spark-3.1.x 95.97% <100.00%> (ø)
spark-3.2.x 95.97% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re/src/main/scala/doric/syntax/Interpolators.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae94977...bea53bd. Read the comment docs.

@eruizalo eruizalo enabled auto-merge (squash) March 29, 2022 06:57
@eruizalo eruizalo merged commit a74e078 into hablapps:main Mar 29, 2022
@eruizalo eruizalo deleted the fix/191-bug-report-interpolator-outputs-null branch March 29, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix PR fixes spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report]: Interpolator outputs null if one column is null
2 participants