Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic invocations for Row columns and top row #211

Merged
merged 16 commits into from
May 26, 2022
Merged

Dynamic invocations for Row columns and top row #211

merged 16 commits into from
May 26, 2022

Conversation

jserranohidalgo
Copy link
Member

@jserranohidalgo jserranohidalgo commented Apr 26, 2022 •
edited
Loading

Implements #210.

@alfonsorr @eruizalo please, review

@jserranohidalgo jserranohidalgo requested a review from a team as a code owner April 26, 2022 09:46
@jserranohidalgo
Copy link
Member Author

I think the only functional change besides issue #211 is the column name reported in getChild:
https://github.com/hablapps/doric/pull/211/files#diff-70f22bf02d4c37d3754f01dbdbeed684fa51f3cc4de77570e3dd26116f2e6eddR76

@codecov
Copy link

codecov bot commented Apr 26, 2022 •
edited
Loading

Codecov Report

Merging #211 (bead720) into main (e1c9a77) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   95.97%   96.00%   +0.04%     
==========================================
  Files          53       53              
  Lines         794      801       +7     
  Branches        9       12       +3     
==========================================
+ Hits          762      769       +7     
  Misses         32       32
Flag Coverage Δ
spark-2.4.x 93.10% <100.00%> (+0.06%) ⬆️
spark-3.0.x 94.79% <100.00%> (+0.03%) ⬆️
spark-3.1.x 95.95% <100.00%> (+0.02%) ⬆️
spark-3.2.x 95.95% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
core/src/main/scala/doric/DoricColumn.scala 77.14% <ø> (ø)
core/src/main/scala/doric/doric.scala 92.86% <100.00%> (+1.95%) ⬆️
core/src/main/scala/doric/syntax/ColGetters.scala 86.96% <100.00%> (+0.59%) ⬆️
core/src/main/scala/doric/syntax/DStructs.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c9a77...bead720. Read the comment docs.

@jserranohidalgo jserranohidalgo linked an issue Apr 26, 2022 that may be closed by this pull request
Enable dynamic invocations for Row columns #210
Closed
@eruizalo eruizalo added enhancement New feature or request spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 labels May 9, 2022
eruizalo
eruizalo previously approved these changes May 9, 2022
View reviewed changes
core/src/main/scala/doric/syntax/ColGetters.scala Outdated Show resolved Hide resolved
core/src/main/scala/doric/syntax/DStructs.scala Outdated Show resolved Hide resolved
@github-actions github-actions bot removed spark_3.1 PR changes to spark 3.1 spark_3.0 PR changes to spark 3.0 spark_3.2 PR changes to spark 3.2 labels May 24, 2022
@jserranohidalgo
Copy link
Member Author

@eruizalo @alfonsorr I just updated the documentation. Please, review, thx!

alfonsorr
alfonsorr approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@alfonsorr alfonsorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really love to see that with the tools we started creating we are making a full improved API 😄

@alfonsorr alfonsorr requested a review from eruizalo May 25, 2022 15:29
@alfonsorr
Copy link
Member

https://jserranohidalgo.github.io/doric/docs/syntax/#scala-dynamic

@eruizalo eruizalo added spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_2.4 PR changes to spark 2.4 labels May 25, 2022
@eruizalo eruizalo merged commit e312f4d into hablapps:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eruizalo eruizalo eruizalo approved these changes

@alfonsorr alfonsorr alfonsorr approved these changes

Assignees

@jserranohidalgo jserranohidalgo

Labels
enhancement New feature or request spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable dynamic invocations for Row columns
3 participants
@jserranohidalgo @alfonsorr @eruizalo