Feat/212 custom matchers for testing #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With the new changes we may found the following scenarios: 2 errors => 1 ok, 1 ko
2 errors => 2 ko
1 error ko
expected and actual number of errors does not match
|
eruizalo
force-pushed
the
feat/212-custom-matchers-for-testing
branch
2 times, most recently
from
fe89c2e
to
37c8fdb
Compare
eruizalo
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 96.00% 96.45% +0.44%
==========================================
Files 53 53
Lines 801 816 +15
Branches 11 10 -1
==========================================
+ Hits 769 787 +18
+ Misses 32 29 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eruizalo
force-pushed
the
feat/212-custom-matchers-for-testing
branch
from
37c8fdb
to
fe8fd1c
Compare
github-actions
bot
removed
spark_3.2
github-actions
bot
added
spark_2.4
eruizalo
force-pushed
the
feat/212-custom-matchers-for-testing
branch
from
11983c7
to
c8cf00e
Compare
* Renamed ColumnMultyTypeError --> ColumnMultiTypeError * SparkErrorWrapper now overrides equals and hashCode * CustomMatcher with better error messages
eruizalo
force-pushed
the
feat/212-custom-matchers-for-testing
branch
from
e1be01f
to
26ef2c6
Compare
alfonsorr
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Custom matchers for testing Doric expected errors
Related Issue
#212
Motivation and Context
This change simplifies internal testing. It also tests like "normal" spark behaviour.
How Has This Been Tested?