Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [+] #66 math functions #223

Merged
merged 7 commits into from
Jul 13, 2022
Merged

Conversation

eruizalo
Copy link
Collaborator

@eruizalo eruizalo commented Jun 1, 2022

Description

New math functions and testing methods

Related Issue

resolves #66

How Has This Been Tested?

  • This pull request contains appropriate tests?: YES

@eruizalo eruizalo linked an issue Jun 1, 2022 that may be closed by this pull request
97 tasks
@github-actions github-actions bot added spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 labels Jun 1, 2022
@eruizalo eruizalo mentioned this pull request Jun 1, 2022
97 tasks
alfonsorr
alfonsorr previously approved these changes Jun 10, 2022
@alfonsorr
Copy link
Member

mathematical

@eruizalo eruizalo force-pushed the feat/66-math-functions branch 3 times, most recently from f23a20e to ebc2a24 Compare June 24, 2022 10:57
@github-actions github-actions bot added the spark_3.3 PR changes to spark 3.3 label Jun 24, 2022
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #223 (7b3087f) into main (e9e0f6c) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   96.64%   96.88%   +0.24%     
==========================================
  Files          54       58       +4     
  Lines         952     1026      +74     
  Branches       14       14              
==========================================
+ Hits          920      994      +74     
  Misses         32       32              
Flag Coverage Δ
spark-2.4.x 93.47% <100.00%> (+0.46%) ⬆️
spark-3.0.x 96.09% <100.00%> (+0.27%) ⬆️
spark-3.1.x 96.99% <100.00%> (+0.21%) ⬆️
spark-3.2.x 96.99% <100.00%> (+0.21%) ⬆️
spark-3.3.x 96.99% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ore/src/main/scala/doric/syntax/IntegralType.scala 100.00% <100.00%> (ø)
.../main/scala/doric/syntax/NumWithDecimalsType.scala 100.00% <100.00%> (ø)
...e/src/main/scala/doric/syntax/NumericColumns.scala 100.00% <100.00%> (ø)
...re/src/main/scala/doric/syntax/StringColumns.scala 100.00% <100.00%> (ø)
....0_3.1/scala/doric/syntax/NumericColumns2_31.scala 100.00% <100.00%> (ø)
..._3.2_3.3/scala/doric/syntax/NumericColumns31.scala 100.00% <100.00%> (ø)
..._3.2_3.3/scala/doric/syntax/NumericColumns32.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9e0f6c...7b3087f. Read the comment docs.

@eruizalo eruizalo marked this pull request as ready for review June 24, 2022 11:03
@eruizalo eruizalo requested a review from a team as a code owner June 24, 2022 11:03
This was referenced Jun 24, 2022
@eruizalo eruizalo enabled auto-merge (squash) July 12, 2022 18:04
@eruizalo eruizalo merged commit 9955ab6 into hablapps:main Jul 13, 2022
@eruizalo eruizalo deleted the feat/66-math-functions branch July 13, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Math functions
2 participants