Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doric error message now doesn't show the same error multiple times. #226

Merged

Conversation

alfonsorr
Copy link
Member

Improved the message we show skipping the same error multiple times

  • This pull request contain appropriate tests?

@alfonsorr alfonsorr requested a review from a team as a code owner June 8, 2022 15:31
@github-actions github-actions bot added spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 labels Jun 8, 2022
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #226 (89f7075) into main (8ebb166) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
- Coverage   96.45%   96.37%   -0.07%     
==========================================
  Files          53       53              
  Lines         816      827      +11     
  Branches       10       12       +2     
==========================================
+ Hits          787      797      +10     
- Misses         29       30       +1     
Flag Coverage Δ
spark-2.4.x 93.59% <100.00%> (-0.04%) ⬇️
spark-3.0.x 95.29% <100.00%> (+0.05%) ⬆️
spark-3.1.x 96.41% <100.00%> (+0.04%) ⬆️
spark-3.2.x 96.41% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
core/src/main/scala/doric/sem/Errors.scala 94.44% <100.00%> (-0.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ebb166...89f7075. Read the comment docs.

@eruizalo eruizalo merged commit 091998e into hablapps:main Jun 9, 2022
@alfonsorr alfonsorr deleted the feature/doric_columns_errors_as_set branch June 9, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants