Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare doric for spark 3.3.0 #231

Merged
merged 6 commits into from
Jun 24, 2022

Conversation

alfonsorr
Copy link
Member

Spark 3.3.0 is out

Description

Doric will be super fast to introduce the new spark 3.3.x version

Related Issue

None

Motivation and Context

New methods, more performance.

How Has This Been Tested?

Build against the new release

  • This pull request contains appropriate tests?

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #231 (23f453d) into main (e91ba9c) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   96.83%   96.61%   -0.22%     
==========================================
  Files          53       53              
  Lines         946      943       -3     
  Branches       10       11       +1     
==========================================
- Hits          916      911       -5     
- Misses         30       32       +2     
Flag Coverage Δ
spark-2.4.x 92.93% <100.00%> (-0.26%) ⬇️
spark-3.0.x 95.78% <100.00%> (-0.01%) ⬇️
spark-3.1.x 96.75% <100.00%> (-0.01%) ⬇️
spark-3.2.x 96.75% <100.00%> (-0.01%) ⬇️
spark-3.3.x 96.75% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
core/src/main/scala/doric/doric.scala 94.12% <ø> (-0.33%) ⬇️
...re/src/main/scala/doric/syntax/StringColumns.scala 100.00% <ø> (ø)
....0_3.1/scala/doric/syntax/BinaryColumns30_31.scala 100.00% <ø> (ø)
....1_3.2_3.3/scala/doric/syntax/ArrayColumns3x.scala 100.00% <ø> (ø)
...1_3.2_3.3/scala/doric/syntax/CommonColumns3x.scala 100.00% <ø> (ø)
..._3.1_3.2_3.3/scala/doric/syntax/MapColumns3x.scala 100.00% <ø> (ø)
....1_3.2_3.3/scala/doric/syntax/StringColumn3x.scala 100.00% <ø> (ø)
..._3.3/scala/doric/syntax/AggregationColumns31.scala 100.00% <ø> (ø)
..._3.2_3.3/scala/doric/syntax/BooleanColumns31.scala 100.00% <ø> (ø)
..._3.2_3.3/scala/doric/syntax/NumericColumns31.scala 100.00% <ø> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e91ba9c...23f453d. Read the comment docs.

@github-actions github-actions bot added CI/CD Continuous integration and continuous delivery spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 labels Jun 17, 2022
@alfonsorr alfonsorr added the spark_3.3 PR changes to spark 3.3 label Jun 18, 2022
@hablapps hablapps deleted a comment from alfonsorr Jun 19, 2022
eruizalo
eruizalo previously approved these changes Jun 19, 2022
@alfonsorr alfonsorr marked this pull request as ready for review June 22, 2022 10:07
@alfonsorr alfonsorr requested a review from a team as a code owner June 22, 2022 10:07
@alfonsorr alfonsorr requested a review from eruizalo June 22, 2022 10:07
@alfonsorr alfonsorr requested a review from eruizalo June 24, 2022 07:31
@alfonsorr alfonsorr merged commit 0b3f5e7 into hablapps:main Jun 24, 2022
@alfonsorr alfonsorr deleted the feature/doric_spark_3_3 branch June 29, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continuous integration and continuous delivery spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants