Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/scala 2.13 for spark 3.3.x and 3.2.x #238

Merged
merged 6 commits into from
Jul 13, 2022

Conversation

alfonsorr
Copy link
Member

@alfonsorr alfonsorr commented Jun 29, 2022

Spark since 3.2.x is releasing scala 2.13 versions, now doric is also using this to publish in 2.13 scala version.

Description

CI and code changes to allow the build for scala 2.13

Related Issue

resolves #237

How Has This Been Tested?

Local builds for both spark versions against the two scala versions accepted

  • This pull request contains appropriate tests?: YES

@github-actions github-actions bot added spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3 labels Jun 29, 2022
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #238 (9087110) into main (9955ab6) will increase coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   96.88%   97.28%   +0.40%     
==========================================
  Files          58       58              
  Lines        1026     1028       +2     
  Branches       14       10       -4     
==========================================
+ Hits          994     1000       +6     
+ Misses         32       28       -4     
Flag Coverage Δ
spark-2.4.x 93.91% <100.00%> (+0.44%) ⬆️
spark-3.0.x 96.51% <100.00%> (+0.42%) ⬆️
spark-3.1.x 97.40% <100.00%> (+0.41%) ⬆️
spark-3.2.x 97.40% <100.00%> (+0.41%) ⬆️
spark-3.3.x 97.40% <100.00%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
core/src/main/scala/doric/sem/TransformOps.scala 100.00% <100.00%> (+25.00%) ⬆️
...e/src/main/scala/doric/syntax/NumericColumns.scala 100.00% <100.00%> (ø)
...re/src/main/scala/doric/syntax/StringColumns.scala 100.00% <100.00%> (ø)
.../src/main/scala/doric/types/LiteralSparkType.scala 100.00% <100.00%> (ø)
core/src/main/scala/doric/types/SparkType.scala 95.38% <100.00%> (ø)
...main/scala/doric/implicitConversions/package.scala 100.00% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9955ab6...9087110. Read the comment docs.

@alfonsorr alfonsorr linked an issue Jun 29, 2022 that may be closed by this pull request
@alfonsorr alfonsorr force-pushed the feature/scala_2.13_for_spark_3.3.x branch from d81f5fd to f463233 Compare July 12, 2022 12:22
@github-actions github-actions bot added the CI/CD Continuous integration and continuous delivery label Jul 12, 2022
@alfonsorr alfonsorr marked this pull request as ready for review July 12, 2022 12:30
@alfonsorr alfonsorr requested a review from a team as a code owner July 12, 2022 12:30
@alfonsorr alfonsorr enabled auto-merge (squash) July 13, 2022 07:34
@alfonsorr alfonsorr merged commit 3f90128 into hablapps:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continuous integration and continuous delivery spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Scala 2.13 versions
2 participants