Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [+] remaining non aggregate functions (resolves #68) #262

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

eruizalo
Copy link
Collaborator

@eruizalo eruizalo commented Aug 1, 2022

Description

  • add the remaining non-aggregate functions
  • a small ci change to autotag project/build.properties changes as a dependency PR

Related Issue and dependencies

How Has This Been Tested?

  • This pull request contains appropriate tests?:
    • YES

@eruizalo eruizalo requested a review from a team as a code owner August 1, 2022 15:10
@github-actions github-actions bot added CI/CD Continuous integration and continuous delivery spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3 labels Aug 1, 2022
@eruizalo eruizalo mentioned this pull request Aug 1, 2022
31 tasks
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #262 (e43dda5) into main (db1e2f4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
+ Coverage   97.29%   97.30%   +0.01%     
==========================================
  Files          58       58              
  Lines        1107     1111       +4     
  Branches       15       24       +9     
==========================================
+ Hits         1077     1081       +4     
  Misses         30       30              
Flag Coverage Δ
spark-2.4.x 93.42% <100.00%> (+0.02%) ⬆️
spark-3.0.x 96.59% <100.00%> (+0.01%) ⬆️
spark-3.1.x 97.41% <100.00%> (+0.01%) ⬆️
spark-3.2.x 97.41% <100.00%> (+0.01%) ⬆️
spark-3.3.x 97.41% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/src/main/scala/doric/syntax/NumericColumns.scala 100.00% <100.00%> (ø)
....0_3.1/scala/doric/syntax/NumericColumns2_31.scala 100.00% <100.00%> (ø)
..._3.2_3.3/scala/doric/syntax/NumericColumns32.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db1e2f4...e43dda5. Read the comment docs.

@eruizalo eruizalo force-pushed the feat/68_non_aggregate_functions branch from 45d4c18 to e11fdf6 Compare August 1, 2022 15:34
alfonsorr
alfonsorr previously approved these changes Aug 2, 2022
@alfonsorr alfonsorr self-requested a review August 12, 2022 07:37
@eruizalo eruizalo merged commit c9ad091 into hablapps:main Aug 12, 2022
@eruizalo eruizalo deleted the feat/68_non_aggregate_functions branch August 12, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continuous integration and continuous delivery spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-aggregate functions
2 participants