Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty arrays returns the expected datatype #274

Conversation

alfonsorr
Copy link
Member

@alfonsorr alfonsorr commented Aug 25, 2022

Description

Empty arrays contains a inner datatype of null instead of the type provided in doric, this can create inconsistencies checking the typing and not be what is expected.

Related Issue and dependencies

How Has This Been Tested?

Tests to check the type when the array is empty

  • This pull request contains appropriate tests?:
    • YES

@github-actions github-actions bot added spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3 labels Aug 25, 2022
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #274 (3c34183) into main (552fbc0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 3c34183 differs from pull request most recent head c0ef546. Consider uploading reports for the commit c0ef546 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #274   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files          58       58           
  Lines        1111     1113    +2     
  Branches       11       17    +6     
=======================================
+ Hits         1081     1083    +2     
  Misses         30       30           
Flag Coverage Δ
spark-2.4.x 93.43% <100.00%> (+0.01%) ⬆️
spark-3.0.x 96.60% <100.00%> (+0.01%) ⬆️
spark-3.1.x 97.41% <100.00%> (+<0.01%) ⬆️
spark-3.2.x 97.41% <100.00%> (+<0.01%) ⬆️
spark-3.3.x 97.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ore/src/main/scala/doric/syntax/ArrayColumns.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 552fbc0...c0ef546. Read the comment docs.

@alfonsorr alfonsorr self-assigned this Aug 26, 2022
@alfonsorr alfonsorr force-pushed the 273-bug-report-empty-array-collection-is-of-type-arraynull branch from eb26eb9 to 3c34183 Compare August 26, 2022 10:23
@alfonsorr alfonsorr marked this pull request as ready for review August 26, 2022 10:30
@alfonsorr alfonsorr requested a review from a team as a code owner August 26, 2022 10:30
@alfonsorr alfonsorr force-pushed the 273-bug-report-empty-array-collection-is-of-type-arraynull branch from 3c34183 to c0ef546 Compare August 26, 2022 10:31
@eruizalo eruizalo merged commit 3363221 into hablapps:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report]: Empty array collection is of type Array[Null]
2 participants