-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [+] #270 array_sort functions working with lambdas #275
Merged
eruizalo
merged 5 commits into
hablapps:main
from
eruizalo:feat/270-array_sort-functions_with_lambdas
Sep 7, 2022
Merged
feat: [+] #270 array_sort functions working with lambdas #275
eruizalo
merged 5 commits into
hablapps:main
from
eruizalo:feat/270-array_sort-functions_with_lambdas
Sep 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 97.30% 97.34% +0.04%
==========================================
Files 58 58
Lines 1113 1128 +15
Branches 19 19
==========================================
+ Hits 1083 1098 +15
Misses 30 30
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
59b416f
to
9601156
Compare
alfonsorr
approved these changes
Sep 7, 2022
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API
breaking 💣
Breaking changes
bug 🐛
Something isn't working
enhancement
New feature or request
spark_2.4
PR changes to spark 2.4
spark_3.0
PR changes to spark 3.0
spark_3.1
PR changes to spark 3.1
spark_3.2
PR changes to spark 3.2
spark_3.3
PR changes to spark 3.3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sort
function with a lambda of two params. Now we provide an api not available until spark 3.4 (only available through sql expressions).sort
function with a lambda of one param. I have to thank @alfonsorr for this one, as it is his own idea, implementation. This functions is not available in any version of spark (yet).filterWIndex
from now on will be only available for spark 3.0+ (we have being testing this function only for spark 3.0+ and the filter function for spark 2.4 does not allow a lambda with 2 variables, so it would fail)exists
array function have being tested only for spark 3.0+, but it is available for all spark versions. Now it will be tested for all versionscreateLambda
functions have being copied/pasted from spark code in order to test some lambda functions available in doric but not available in older versions of spark apiRelated Issue and dependencies
How Has This Been Tested?