Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [+] #271 unary functions (-) & (!) #276

Merged

Conversation

eruizalo
Copy link
Collaborator

Description

Unary functions:

  • Add minus(-) for numeric columns
  • Fix not(!) for boolean columns

Related Issue and dependencies

How Has This Been Tested?

  • This pull request contains appropriate tests?:
    • YES

@eruizalo eruizalo requested a review from a team as a code owner August 30, 2022 10:08
@github-actions github-actions bot added spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3 labels Aug 30, 2022
@eruizalo eruizalo force-pushed the feat/271-unary_functions_minus_not branch from 3fb5db2 to 06cb288 Compare August 30, 2022 10:18
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #276 (06cb288) into main (3363221) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   97.30%   97.31%           
=======================================
  Files          58       58           
  Lines        1113     1114    +1     
  Branches       19       24    +5     
=======================================
+ Hits         1083     1084    +1     
  Misses         30       30           
Flag Coverage Δ
spark-2.4.x 93.44% <100.00%> (+0.01%) ⬆️
spark-3.0.x 96.60% <100.00%> (+<0.01%) ⬆️
spark-3.1.x 97.42% <100.00%> (+<0.01%) ⬆️
spark-3.2.x 97.42% <100.00%> (+<0.01%) ⬆️
spark-3.3.x 97.42% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/src/main/scala/doric/syntax/BooleanColumns.scala 100.00% <100.00%> (ø)
...e/src/main/scala/doric/syntax/NumericColumns.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3363221...06cb288. Read the comment docs.

@eruizalo eruizalo enabled auto-merge (squash) August 31, 2022 11:40
@eruizalo eruizalo merged commit c0b4ee0 into hablapps:main Sep 7, 2022
@eruizalo eruizalo deleted the feat/271-unary_functions_minus_not branch September 7, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Use minus (-) symbol to negate NumericColumns
2 participants