feat: [+] pr comment with test summary per spark version #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eruizalo
force-pushed
the
feat/test_summary
branch
2 times, most recently
from
0cc581a
to
b233f0b
Compare
eruizalo
force-pushed
the
feat/test_summary
branch
4 times, most recently
from
ac54e1a
to
0424a66
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 58 58
Lines 1129 1129
Branches 13 13
=======================================
Hits 1099 1099
Misses 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
eruizalo
force-pushed
the
feat/test_summary
branch
from
828d9e2
to
8850dff
Compare
eruizalo
force-pushed
the
feat/test_summary
branch
from
d58685b
to
1db96ae
Compare
alfonsorr
previously approved these changes
Sep 27, 2022
alfonsorr
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is trying to get the testing more visible and accessible. Thanks to this we could see the incrementing number of tests across different versions and detect if a test should be somewhere else. This may not be the best solution, but it is a starting point.
Related Issue and dependencies
How Has This Been Tested?
From now on we can also see a GITHUB_SUMMARY or each run (go to each run to see it)
If everything is OK
Add PR comment, showing everything is ok and how many tests
PR comment: https://github.com/eruizalo/doric/actions/runs/3152756468
CI: https://github.com/eruizalo/doric/actions/runs/3152678869
If some tests fail
Add PR comment, showing test failures
If PR comment workflow fail (because no artifacts found or whatever):
Add a failure comment