Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: [+] literalCol value getter & git hooks #288

Merged
merged 5 commits into from
Oct 24, 2022

Conversation

eruizalo
Copy link
Collaborator

Description

  • [+] git hooks examples in case they are useful for anyone else
  • [+] Doric columns getter in case they are literal columns. With this function we will be able to validate some functions (i.e. with require) before spark.

Related Issue and dependencies

  • Resolves N/A
  • Depends on N/A

How Has This Been Tested?

  • This pull request contains appropriate tests?:
    • YES

@eruizalo eruizalo requested a review from a team as a code owner October 10, 2022 12:31
@github-actions github-actions bot added CI/CD Continuous integration and continuous delivery spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3 labels Oct 10, 2022
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #288 (753610f) into main (5ff2fda) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   97.35%   97.35%   +0.01%     
==========================================
  Files          58       58              
  Lines        1131     1134       +3     
  Branches       13       15       +2     
==========================================
+ Hits         1101     1104       +3     
  Misses         30       30              
Flag Coverage Δ
spark-2.4.x 94.87% <100.00%> (+0.02%) ⬆️
spark-3.0.x 96.66% <100.00%> (+0.01%) ⬆️
spark-3.1.x 97.46% <100.00%> (+0.01%) ⬆️
spark-3.2.x 97.46% <100.00%> (+0.01%) ⬆️
spark-3.3.x 97.46% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/scala/doric/syntax/LiteralConversions.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ff2fda...753610f. Read the comment docs.

@eruizalo eruizalo force-pushed the misc/getLitValue_gitHooks_and_more branch 2 times, most recently from 5e21f61 to ab64ecc Compare October 11, 2022 13:49
@eruizalo eruizalo force-pushed the misc/getLitValue_gitHooks_and_more branch from eaf3c99 to 753610f Compare October 24, 2022 15:00
@eruizalo eruizalo enabled auto-merge (squash) October 24, 2022 15:15
@eruizalo eruizalo merged commit 55beb97 into hablapps:main Oct 24, 2022
@eruizalo eruizalo deleted the misc/getLitValue_gitHooks_and_more branch October 24, 2022 15:16
@eruizalo eruizalo linked an issue Oct 24, 2022 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continuous integration and continuous delivery spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report]: PR comment not working
2 participants