Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/publish doc easier & doc for scala 2.13 & gh actions upgrade #293

Merged
merged 11 commits into from
Jan 20, 2023

Conversation

eruizalo
Copy link
Collaborator

@eruizalo eruizalo commented Oct 24, 2022

Description

Instead of using a matrix or default values that should be maintained, now publish action looks for every scala folder for each spark version and publish it automatically, no need to maintain this workflow by spark/scala versions.

Also, now the api url is a bit more descriptive:

now doric/docs/api/3.0/scala-2.12/api/
after this PR doric/docs/api/spark-3.0/scala-2.12/

ℹ️ UPDATES:

  • 🎉 Now we generate scaladoc (api) for scala 2.13 as well
    • ⚠️ As a counterpart, now it takes more to generate docs 🕥
  • 📝 mdoc generation only if specified in matrix
  • 💪 GH actions upgrade

Related Issue and dependencies

  • Resolves N/A
  • Depends on N/A

How Has This Been Tested?

This has been tested on my own fork:

@eruizalo eruizalo requested a review from a team as a code owner October 24, 2022 09:38
@github-actions github-actions bot added the CI/CD Continuous integration and continuous delivery label Oct 24, 2022
@eruizalo eruizalo added the documentation Improvements or additions to documentation label Oct 24, 2022
@eruizalo eruizalo enabled auto-merge (squash) October 24, 2022 12:35
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Oct 24, 2022
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #293 (462a443) into main (97815ea) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   97.35%   97.35%           
=======================================
  Files          58       58           
  Lines        1134     1134           
  Branches       15       17    +2     
=======================================
  Hits         1104     1104           
  Misses         30       30           
Flag Coverage Δ
spark-2.4.x 94.87% <ø> (ø)
spark-3.0.x 96.66% <ø> (ø)
spark-3.1.x 97.46% <ø> (ø)
spark-3.2.x 97.46% <ø> (ø)
spark-3.3.x 97.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97815ea...462a443. Read the comment docs.

@eruizalo eruizalo force-pushed the ci/publish_doc_easier branch 2 times, most recently from 91b4855 to bb4c77e Compare October 24, 2022 16:03
@github-actions
Copy link

github-actions bot commented Oct 24, 2022

:octocat: This is an auto-generated comment created by:

  • Date : 2023-01-20 11:24:38 +0000 (UTC)
  • Workflow : PR comment
  • Job name : create_test_summary_report
  • Run : 3967188480
  • Commit : 462a443 rename GitHub actions doc jobs
Actor Triggering actor Sender
eruizalo
eruizalo
eruizalo
eruizalo
eruizalo
eruizalo
Triggered by:

Test summary report 📊

Spark version testing
2.4.1 588 passed, 2 skipped
2.4.2 588 passed, 2 skipped
2.4.3 588 passed, 2 skipped
2.4.4 588 passed, 2 skipped
2.4.5 588 passed, 2 skipped
2.4.6 589 passed, 2 skipped
2.4.7 589 passed, 2 skipped
2.4 589 passed, 2 skipped
3.0.0 621 passed, 2 skipped
3.0.1 621 passed, 2 skipped
3.0.2 621 passed, 2 skipped
3.0 621 passed, 2 skipped
3.1.0 649 passed, 2 skipped
3.1.1 649 passed, 2 skipped
3.1.2 649 passed, 2 skipped
3.1 649 passed, 2 skipped
3.2.0 650 passed, 2 skipped
3.2.1 650 passed, 2 skipped
3.2 650 passed, 2 skipped
3.3 650 passed, 2 skipped

@eruizalo eruizalo force-pushed the ci/publish_doc_easier branch 6 times, most recently from 573a8f2 to 2c15f9a Compare December 28, 2022 20:05
@eruizalo eruizalo force-pushed the ci/publish_doc_easier branch 4 times, most recently from 1340b17 to 6f46b6d Compare December 29, 2022 12:26
@eruizalo eruizalo changed the title Ci/publish doc easier Ci/publish doc easier & doc for scala 2.13 & gh actions upgrade Dec 30, 2022
@eruizalo eruizalo merged commit eed780a into hablapps:main Jan 20, 2023
@eruizalo eruizalo deleted the ci/publish_doc_easier branch January 20, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continuous integration and continuous delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants