Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: [~] dependabot now will never execute publish doc #330

Merged

Conversation

eruizalo
Copy link
Collaborator

Description

Dependabot was failing at publish_doc workflow:

Starting March 1st, 2021 workflow runs that are triggered by Dependabot from push, pull_request, pull_request_review, or pull_request_review_comment events will be treated as if they were opened from a repository fork. This means they will receive a read-only GITHUB_TOKEN and will not have access to any secrets available in the repository. This will cause any workflows that attempt to write to the repository to fail.

This change will affect all repositories, both public and private, regardless of how they are configured, and is being made to prevent potentially compromised dependencies from capturing secrets referenced in your workflows.

Because of this we decided to disable the publish_doc workflows for these branches. It should not fail generating doc and the remaining builds will show up any possible errors.

Related Issue and dependencies

  • Resolves N/A
  • Depends on N/A

How Has This Been Tested?

  • This pull request contains appropriate tests?:
    • NO

@eruizalo eruizalo requested a review from a team as a code owner February 22, 2023 09:47
@github-actions github-actions bot added the CI/CD Continuous integration and continuous delivery label Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #330 (b1ac13a) into main (62b79f4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #330   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files          60       60           
  Lines        1164     1164           
  Branches       18       19    +1     
=======================================
  Hits         1134     1134           
  Misses         30       30           
Flag Coverage Δ
spark-2.4.x 94.69% <ø> (ø)
spark-3.0.x 96.48% <ø> (ø)
spark-3.1.x 97.29% <ø> (ø)
spark-3.2.x 97.53% <ø> (ø)
spark-3.3.x 97.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62b79f4...b1ac13a. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 22, 2023

:octocat: This is an auto-generated comment created by:

  • Date : 2023-02-22 09:57:46 +0000 (UTC)
  • Workflow : PR comment
  • Job name : create_test_summary_report
  • Run : 4241498288
  • Commit : b1ac13a ci: [~] dependabot now will never execute publish doc
Actor Triggering actor Sender
eruizalo
eruizalo
eruizalo
eruizalo
eruizalo
eruizalo
Triggered by:

Test summary report 📊

Spark version testing
2.4.1 588 passed, 2 skipped
2.4.2 588 passed, 2 skipped
2.4.3 588 passed, 2 skipped
2.4.4 588 passed, 2 skipped
2.4.5 588 passed, 2 skipped
2.4.6 589 passed, 2 skipped
2.4.7 589 passed, 2 skipped
2.4 589 passed, 2 skipped
3.0.0 621 passed, 2 skipped
3.0.1 621 passed, 2 skipped
3.0.2 621 passed, 2 skipped
3.0 621 passed, 2 skipped
3.1.0 649 passed, 2 skipped
3.1.1 649 passed, 2 skipped
3.1.2 649 passed, 2 skipped
3.1 649 passed, 2 skipped
3.2.0 653 passed, 2 skipped
3.2.1 653 passed, 2 skipped
3.2.2 653 passed, 2 skipped
3.2 653 passed, 2 skipped
3.3.0 653 passed, 2 skipped
3.3 653 passed, 2 skipped

@eruizalo eruizalo added the documentation Improvements or additions to documentation label Feb 22, 2023
Copy link

@Ernesto-VL Ernesto-VL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eruizalo eruizalo merged commit 87459a4 into hablapps:main Feb 22, 2023
@eruizalo eruizalo deleted the ci/dependabot_page_build_wont_execute branch February 22, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continuous integration and continuous delivery documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants