Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-272: Add String Comparison operators #355

Conversation

Amalicia
Copy link
Contributor

Description

This PR adds the following comparison operators to String columns: <, <=, > and >=.

Whilst I'm touching parts like this if there are any other comparison operators for other types then please let me know, I'm more than happy to add them.

Related Issue and dependencies

How Has This Been Tested?

  • This pull request contains appropriate tests?:
    • YES
    • New unit tests added for each comparison operator

@Amalicia Amalicia requested a review from a team as a code owner May 12, 2023 11:10
@github-actions github-actions bot added spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3 labels May 12, 2023
@github-actions
Copy link

github-actions bot commented May 12, 2023

:octocat: This is an auto-generated comment created by:

  • Date : 2023-05-12 11:29:22 +0000 (UTC)
  • Workflow : PR comment
  • Job name : create_test_summary_report
  • Run : 4958327544
  • Commit : b720a6b Issue-272: Fix formatting
Actor Triggering actor Sender
Amalicia
Amalicia
Amalicia
Amalicia
Amalicia
Amalicia
Triggered by:

Test summary report 📊

Spark version testing
2.4.1 627 passed, 2 skipped
2.4.2 627 passed, 2 skipped
2.4.3 627 passed, 2 skipped
2.4.4 627 passed, 2 skipped
2.4.5 627 passed, 2 skipped
2.4.6 628 passed, 2 skipped
2.4.7 628 passed, 2 skipped
2.4 628 passed, 2 skipped
3.0.0 678 passed, 2 skipped
3.0.1 678 passed, 2 skipped
3.0.2 678 passed, 2 skipped
3.0 678 passed, 2 skipped
3.1.0 706 passed, 2 skipped
3.1.1 706 passed, 2 skipped
3.1.2 706 passed, 2 skipped
3.1 706 passed, 2 skipped
3.2.0 710 passed, 2 skipped
3.2.1 710 passed, 2 skipped
3.2.2 710 passed, 2 skipped
3.2 710 passed, 2 skipped
3.3.0 710 passed, 2 skipped
3.3.1 710 passed, 2 skipped
3.3 710 passed, 2 skipped

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #355 (b720a6b) into main (8eef33d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
+ Coverage   97.60%   97.61%   +0.01%     
==========================================
  Files          62       62              
  Lines        1249     1253       +4     
  Branches       23       16       -7     
==========================================
+ Hits         1219     1223       +4     
  Misses         30       30              
Flag Coverage Δ
spark-2.4.x 94.68% <100.00%> (+0.02%) ⬆️
spark-3.0.x 96.75% <100.00%> (+0.01%) ⬆️
spark-3.1.x 97.49% <100.00%> (+0.01%) ⬆️
spark-3.2.x 97.71% <100.00%> (+0.01%) ⬆️
spark-3.3.x 97.71% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re/src/main/scala/doric/syntax/StringColumns.scala 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eef33d...b720a6b. Read the comment docs.

Copy link
Member

@alfonsorr alfonsorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alfonsorr alfonsorr merged commit 619e228 into hablapps:main May 16, 2023
@eruizalo eruizalo added enhancement New feature or request API labels May 16, 2023
@Amalicia Amalicia deleted the feature/ISSUE-272-add-string-comparison-operators branch May 16, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Add/review column comparators
3 participants