Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added yazdanhaider's dino contri #1098

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Added yazdanhaider's dino contri #1098

merged 4 commits into from
Sep 19, 2024

Conversation

yazdanhaider
Copy link
Contributor

No description provided.

@yazdanhaider
Add files via upload
5fc3c17
@yazdanhaider
yazdanhaider_dino
a8c6b81 
Added dino for yazdanhaider's commit
DillonB07
DillonB07 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@DillonB07 DillonB07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice dino!

DillonB07
DillonB07 requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@DillonB07 DillonB07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add this to the bottom of the readme file not the top

@DillonB07 DillonB07 added needs readme commit Needs the dinosaur added to the readme so everyone can see it :) needs readme update Dino incorrectly added to readme and removed needs readme commit Needs the dinosaur added to the readme so everyone can see it :) labels Sep 6, 2024
@Shrey-Mehra Shrey-Mehra requested review from Shrey-Mehra and removed request for maxwofford September 18, 2024 11:19
@crabby605 crabby605 closed this Sep 19, 2024
@crabby605 crabby605 reopened this Sep 19, 2024
NeonGamerBot-QK
NeonGamerBot-QK requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@NeonGamerBot-QK NeonGamerBot-QK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts

@DillonB07
Copy link
Contributor

Hi @crabby605 this isn't ready to be merged yet because you're adding your dinosaur at the top of the file. Please modify the README.md to add it at the bottom by moving the lines you've added

@Shrey-Mehra
Copy link
Contributor

Hey @DillonB07
Within 1-2 I'll resolve conflict because it can be resolved from our end only

@crabby605
Copy link

Hi @crabby605 this isn't ready to be merged yet because you're adding your dinosaur at the top of the file. Please modify the README.md to add it at the bottom by moving the lines you've added

Nah the closure of PR was accidental

Shrey-Mehra
Shrey-Mehra approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@Shrey-Mehra Shrey-Mehra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging it as I settled everything

@Shrey-Mehra Shrey-Mehra merged commit ecb34d8 into hackclub:main Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeonGamerBot-QK NeonGamerBot-QK NeonGamerBot-QK requested changes

@DillonB07 DillonB07 DillonB07 requested changes

@Shrey-Mehra Shrey-Mehra Shrey-Mehra approved these changes

Assignees
No one assigned
Labels
needs readme update Dino incorrectly added to readme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yazdanhaider @DillonB07 @Shrey-Mehra @crabby605 @NeonGamerBot-QK