Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arpan to the teams page #978

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Add Arpan to the teams page #978

merged 6 commits into from
Oct 27, 2023

Conversation

Arpan-206
Copy link
Member

No description provided.

Copy link
Contributor

@grymmy grymmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly request this PR be cleaned up to only modify lines that need modifying per the goal of the PR... if a separate pass is desired to clean up style, it would be best to gather consensus on what style the whole repo should use - otherwise people are just muddying the history with whatever their own (or likely, their IDE's) preferences are...

@Arpan-206 Arpan-206 changed the title Add Arpan to the teams page + Move Holly Add Arpan to the teams page Oct 27, 2023
Copy link
Contributor

@grymmy grymmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our discussion I will follow up on practical ways we might be more consistent with our seemingly agreed-upon style

@grymmy grymmy merged commit 9fd5c61 into hackclub:main Oct 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants