Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plausible server side analytics #2308

Merged
merged 1 commit into from
Sep 18, 2024
Merged

add plausible server side analytics #2308

merged 1 commit into from
Sep 18, 2024

Conversation

recursiveforte
Copy link
Member

@recursiveforte recursiveforte commented Sep 6, 2024

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 8:53pm

@JosiasAurel
Copy link
Contributor

Why are we adding this?

Copy link
Contributor

@JosiasAurel JosiasAurel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please see comment

},
body: JSON.stringify({
domain: "sprig.hackclub.com",
url: request.url,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we exclude /api/ endpoints in these analytics?

@JosiasAurel
Copy link
Contributor

Do we still intend to add plausible analytics?

@recursiveforte recursiveforte added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 3180988 Sep 18, 2024
4 of 6 checks passed
@recursiveforte recursiveforte deleted the analytics branch September 18, 2024 14:20
recursiveforte added a commit that referenced this pull request Sep 18, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 18, 2024
Revert "add plausible server side analytics (#2308)"

This reverts commit 3180988.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants