Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty continuation lines in Dockerfile #62

Conversation

moosichu
Copy link
Contributor

@moosichu moosichu commented Oct 2, 2017

No description provided.

@moosichu moosichu requested a review from jaredkhan October 2, 2017 16:04
@jaredkhan
Copy link
Contributor

Could you explain why this was needed?

@moosichu
Copy link
Contributor Author

moosichu commented Oct 2, 2017

See pull request #60 , empty continuation lines will be deprecated in future versions of docker.

Further reading for background info: moby/moby#29005

@Pinpickle
Copy link
Contributor

Pinpickle commented Oct 2, 2017

Not super problematic here though as we're not really doing any cleanup in these run commands - splitting them up shouldn't have too much overhead. I'm not that clued-up on Docker internals though.

Thought we were in the issue... @moosichu did we swap realities for a moment?

#60 (comment)

jaredkhan
jaredkhan previously approved these changes Oct 6, 2017
Copy link
Contributor

@jaredkhan jaredkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could maybe be tidied up more but happy to go ahead

@moosichu moosichu merged commit 5839394 into hackersatcambridge:master Oct 12, 2017
@moosichu moosichu deleted the warn-fix/remove-empty-continuation-lines branch October 13, 2017 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants