Code

Instructor steps#1

Code

Open

bhserna wants to merge 54 commits intomasterhackerschoolmty/ruby102:masterfrom instructor-stepshackerschoolmty/ruby102:instructor-stepsCopy head branch name to clipboard

+694-3

Commits

Commits on Jun 12, 2016

• first test

  bhserna

  committed
  14230cc

  Copy full SHA for 14230cc

• enough code to make the first test pass

  bhserna

  committed
  d0356d1

  Copy full SHA for d0356d1

• second test

  bhserna

  committed
  663cb24

  Copy full SHA for 663cb24

• second test is green

  bhserna

  committed
  5d509d8

  Copy full SHA for 5d509d8

• third test

  bhserna

  committed
  b4e2bee

  Copy full SHA for b4e2bee

• third test is green

  bhserna

  committed
  21c48d5

  Copy full SHA for 21c48d5

• small refactor

  bhserna

  committed
  52b09b2

  Copy full SHA for 52b09b2

• moves inventory to its own file

  bhserna

  committed
  4fa4321

  Copy full SHA for 4fa4321

• rendering with sinatra

  bhserna

  committed
  05eb102

  Copy full SHA for 05eb102

• view for new article

  bhserna

  committed
  1dbd496

  Copy full SHA for 1dbd496

• inspect params

  bhserna

  committed
  4dec278

  Copy full SHA for 4dec278

• expect and :add_inventory method

  bhserna

  committed
  f3dc99a

  Copy full SHA for f3dc99a

• problem with the hash keys

  bhserna

  committed
  4bd6645

  Copy full SHA for 4bd6645

• expect string params

  bhserna

  committed
  9907550

  Copy full SHA for 9907550

• adds create method to Store

  bhserna

  committed
  19f7cfc

  Copy full SHA for 19f7cfc

• refactor to introduce an InMemoryStore that will be used in the app and in tests

  bhserna

  committed
  7a6d0ee

  Copy full SHA for 7a6d0ee

• a little design to expect errors when an article is added

  bhserna

  committed
  00b6294

  Copy full SHA for 00b6294

• sending the right status

  bhserna

  committed
  94fdca0

  Copy full SHA for 94fdca0

• validates presence of name, but does not handle empty string

  bhserna

  committed
  72361a2

  Copy full SHA for 72361a2

• handle empty string

  bhserna

  committed
  a6b849f

  Copy full SHA for a6b849f

• structure design to show form values

  bhserna

  committed
  cd6d827

  Copy full SHA for cd6d827

• new article form

  bhserna

  committed
  ea44a31

  Copy full SHA for ea44a31

• restore params

  bhserna

  committed
  0cd7a7a

  Copy full SHA for 0cd7a7a

• form show errors but always shows error

  bhserna

  committed
  578e56e

  Copy full SHA for 578e56e

• how to show no errors on empty form?

  bhserna

  committed
  9bf7761

  Copy full SHA for 9bf7761

• little refactor to make ArticleForm to receive an Article

  bhserna

  committed
  b008014

  Copy full SHA for b008014

• separate validation to be able to render the initial form without errors

  bhserna

  committed
  1e8f7e4

  Copy full SHA for 1e8f7e4

• validates presence of quantity but discovering a bug on Article.quantity= (maybe its time to share presence?)

  bhserna

  committed
  2c598fc

  Copy full SHA for 2c598fc

• is working but... should Inventory include Presence?

  bhserna

  committed
  e4814aa

  Copy full SHA for e4814aa

• refactor to introduce an ArticleValidator

  bhserna

  committed
  708ac7d

  Copy full SHA for 708ac7d

• validates quantity is greater than or equals than 0

  bhserna

  committed
  1538b34

  Copy full SHA for 1538b34

• render quantity errors

  bhserna

  committed
  a6f159a

  Copy full SHA for a6f159a

Commits on Jun 13, 2016

• code uniq validation is ready but the validation code is a little funky

  bhserna

  committed
  8cecd6f

  Copy full SHA for 8cecd6f

• validation is a little more clean but still a little funky

  bhserna

  committed
  1cd67cc

  Copy full SHA for 1cd67cc

• introduction of method :send, to clean the code a little, but still not as good as it can be

  bhserna

  committed
  56a9a7e

  Copy full SHA for 56a9a7e

• using splat operator to accept a collection of attributes

  bhserna

  committed
  50753ee

  Copy full SHA for 50753ee

• intruction of define method to remove some duplication... funky code

  bhserna

  committed
  076289f

  Copy full SHA for 076289f

• attempt to build a more generic delegation method

  bhserna

  committed
  06e2e78

  Copy full SHA for 06e2e78

• know we have a generic delegate method, extracted in a Delegate module

  bhserna

  committed
  f6d9ce9

  Copy full SHA for f6d9ce9

• html and api design to increment article quantity

  bhserna

  committed
  d0ca88f

  Copy full SHA for d0ca88f

• first test to increment article quantity

  bhserna

  committed
  a3dcf64

  Copy full SHA for a3dcf64

• make the test green

  bhserna

  committed
  de793e1

  Copy full SHA for de793e1

• uses Article#to_h to create record and fixes an spec

  bhserna

  committed
  c2bc607

  Copy full SHA for c2bc607

• adds update method to store in order to run the app

  bhserna

  committed
  2f843dc

  Copy full SHA for 2f843dc

• html and api to decrement quantity

  bhserna

  committed
  a64b8c6

  Copy full SHA for a64b8c6

• design and refactor to add a test to decrement article quantity

  bhserna

  committed
  23a9464

  Copy full SHA for 23a9464

• the fisrt test to decrement quantity is green

  bhserna

  committed
  c4cf647

  Copy full SHA for c4cf647

• adds an spec to test that the quantity can't go less than 0

  bhserna

  committed
  10cdb7b

  Copy full SHA for 10cdb7b

• do not permit quantity go less than 0

  bhserna

  committed
  7424efa

  Copy full SHA for 7424efa

• a better way to handle decrementing quantity knowledge

  bhserna

  committed
  41111ac

  Copy full SHA for 41111ac

• adds an in file store

  bhserna

  committed
  f7e2aa1

  Copy full SHA for f7e2aa1

• moving files to a better file structure

  bhserna

  committed
  7f9449e

  Copy full SHA for 7f9449e

• Adds Gemfile

  bhserna

  committed
  f0b2ea4

  Copy full SHA for f0b2ea4

• Use sqlite db as storage

  bhserna

  committed
  7974766

  Copy full SHA for 7974766