1141 map select options #1149
1141 map select options #1149
Conversation
|
filters start off empty with an option to select all
clicking select all selects all options
|
|
Checking the "Select All" option checks all not already checked filter types. |
|
I'm looking into the failing build pipeline. |
| onChange={() => updateTypesFilter(type.typeId)} | ||
| /> | ||
| } | ||
| label={type.typeName} | ||
| /> | ||
| ))} | ||
| <FormControlLabel | ||
| key={'all'} |
There was a problem hiding this comment.
I don't think you'll need to wrap the key value in curly braces if it's just a string.
|
Hey Edwin, just left one more tiny comment and everything looks good to go! I haven't had the time to look into the build pipeline yet. You're welcome to look into it if you'd like, otherwise I'll try to resolve it and merge in your PR this weekend. |
|
@joshuayhwu, I just merged some updates into this branch so the build checks pass. |
|
Thanks for the speedy review Joshua! |
Fixes #1141
devbranchAny questions? See the getting started guide