1154 nc boundaries not rendering on dev site #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichhk
requested review from
adamkendis and
joshuayhwu
and removed request for
adamkendis
|
Thanks Josh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1154, #1155
In this PR, we stopped calling or handling getRequestTypes, but we forgot to comment out the actual web request. This caused a shifting error where ncGeoJson actually turns out to be agencies.
Coincidentally, this also makes the auto-complete for the "Council" tab work! The shifting error caused this bug as well.
Bonus: this also fixes address searching.
Note: It's generally a bad practice to leave commented-out code. It makes it very difficult to read the code (why is this commented out? Is this still needed? Is the implementation of the commented-out code correct?). But I'm going to leave it here since I have no idea why we got rid of getRequestTypes.
devbranchAny questions? See the getting started guide