Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate NC name on neighborhood recent dashboard #1243

Merged
merged 12 commits into from
Jun 10, 2022
Merged

Conversation

joshuayhwu
Copy link
Contributor

@joshuayhwu joshuayhwu commented Jun 9, 2022

Fixes #1230

  • Resolve issue with inconsistent NC dropdown and description name, but maintains correct filtering mechanism.

    • All PR Status checks are successful
    • Peer reviewed and approved

Any questions? See the getting started guide

Potentially a additional end-of-line when saving files using vscode, see here

@joshuayhwu joshuayhwu requested a review from nichhk June 9, 2022 07:07
Copy link
Member

@nichhk nichhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josh! A few comments, but looks good to submit afterwards.

server/api/alembic/seeds/types.csv Outdated Show resolved Hide resolved
server/dash/design.py Outdated Show resolved Hide resolved
server/dash/design.py Outdated Show resolved Hide resolved
server/dash/dashboards/neighborhood_recent.py Outdated Show resolved Hide resolved
@joshuayhwu joshuayhwu merged commit 3306004 into dev Jun 10, 2022
@joshuayhwu joshuayhwu deleted the fixName branch June 10, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Incorrect Data on 311 Data Dashboard
2 participants