Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1202 Initial add About page and added to header nav. #1267

Merged
merged 2 commits into from
Jul 8, 2022
Merged

#1202 Initial add About page and added to header nav. #1267

merged 2 commits into from
Jul 8, 2022

Conversation

funbunch
Copy link
Member

@funbunch funbunch commented Jul 2, 2022

Fixes #1202

Current view:
Screen Shot 2022-07-02 at 2 41 44 PM

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@funbunch funbunch changed the title #1264 Initial add About page and added to header nav. #1267 Initial add About page and added to header nav. Jul 2, 2022
@nichhk nichhk self-requested a review July 2, 2022 22:43
Copy link
Member

@nichhk nichhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shannan! Looks good. One small comment.

client/components/Header.jsx Show resolved Hide resolved
@nichhk
Copy link
Member

nichhk commented Jul 2, 2022

Also, the original comment is incorrect--this PR contributes to #1202.

@nichhk
Copy link
Member

nichhk commented Jul 7, 2022

Looks good! Thanks Shannan. Please merge the PR yourself when you're ready.

@funbunch funbunch changed the title #1267 Initial add About page and added to header nav. #1202 Initial add About page and added to header nav. Jul 8, 2022
@funbunch funbunch merged commit 1dc3eaa into dev Jul 8, 2022
@funbunch funbunch deleted the About branch July 8, 2022 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2 Add About Page
2 participants