Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all request types selected by default #1272

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Conversation

funbunch
Copy link
Member

@funbunch funbunch commented Jul 7, 2022

Fixes #1264

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Screen Shot 2022-07-06 at 8 05 05 PM

Any questions? See the getting started guide

@funbunch funbunch changed the title Changing default request types to be selected on load Make all request types selected by default Jul 7, 2022
@nichhk nichhk self-requested a review July 7, 2022 07:01
Copy link
Member

@nichhk nichhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the "Select All" checkbox is unchecked, even though all the request types are selected. Can you modify the TypeSelector to check the "Select All" checkbox if all request types are selected? I believe the change would need to happen in client/components/main/Desktop/TypeSelector/index.js.

@funbunch
Copy link
Member Author

funbunch commented Jul 8, 2022

Updated commit.
Screen Shot 2022-07-07 at 8 12 51 PM

Copy link
Member

@nichhk nichhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

I'll note that the spacing and indentation is not consistent right now, but the linter is disabled on this file anyway.

@nichhk nichhk merged commit 0d502cc into dev Jul 22, 2022
@nichhk nichhk deleted the default-request-types branch July 22, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make all request types selected by default
2 participants