Updated documentation for local client and server setup #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erver in /client/README.md and included CORS policy setting to prevent client-side errors when connecting to local API server in /server/.env.example
2 tasks
nichhk
approved these changes
Aug 17, 2022
client/README.md
Outdated
| @@ -7,7 +7,7 @@ | |||
| - Switch to using Node 12: `nvm use 12` | |||
| - From this directory, `npm run setup` to install front end dependencies and create an `.env` file | |||
| - get a [Mapbox](https://account.mapbox.com/auth/signin/) API token and add that to your `.env` file as the `MAPBOX_TOKEN` | |||
| - get the `API_URL` from a team member and add that to your `.env` file. Alternatively, you can [bring up](https://github.com/hackforla/311-data/blob/dev/docs/server_setup.md) your own local server and use that. | |||
| - get the `API_URL` from a team member and add that to your `.env` file. Alternatively, you can [bring up](https://github.com/hackforla/311-data/blob/dev/docs/server_setup.md) your own local server and use that (if you are running your own local server, set API_URL to 'http://localhost:5000') | |||
There was a problem hiding this comment.
nit: `API_URL` instead of API_URL for consistency
There was a problem hiding this comment.
ok, added the back ticks around API_URL for consistency
edwinjue
deleted the
1315-update-documentation-for-local-client-and-server-setup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1315
devbranchAny questions? See the getting started guide