Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed prefect test test_last_updated() and added pytest==7.1.2 to requirements.txt #1326

Merged
merged 4 commits into from
Aug 24, 2022
Merged

Removed prefect test test_last_updated() and added pytest==7.1.2 to requirements.txt #1326

merged 4 commits into from
Aug 24, 2022

Conversation

edwinjue
Copy link
Member

Fixes #1309

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@edwinjue
added pytest==7.1.2 to /server/prefect/requirements.txt (you may need…
2e762a3 
… to run docker compose build to rebuild)
@edwinjue
removed test_last_updated() test from /server/prefect/tests/test_task…
4d69b82 
…s.py since get_last_updated is no longer defined in tasks/postgres.py
nichhk
nichhk suggested changes Aug 22, 2022
View reviewed changes
Copy link
Member

@nichhk nichhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Edwin!

I also forgot to note that we should run the prefect tests as part of our continuous integration. Could you add that here?

server/prefect/requirements.txt Outdated Show resolved Hide resolved
@edwinjue edwinjue closed this Aug 23, 2022
@edwinjue edwinjue reopened this Aug 23, 2022
nichhk
nichhk approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@nichhk nichhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Edwin! Please merge this at your convenience.

@edwinjue edwinjue merged commit aafd47b into dev Aug 24, 2022
@edwinjue edwinjue deleted the 1309-run-unit-tests-for-prefect branch August 24, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nichhk nichhk nichhk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run unit tests for Prefect
2 participants
@edwinjue @nichhk