-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finished adding the rest of the content. Adjusted grid and styling. #1338
Conversation
@funbunch Thanks for providing me with the figma you used to base your changes on. Everything looks spot on. Besides a few minor things, the only feedback I have is just whether @nichhk would like us to inherit more styles from theme.js. If that is the case, we would likely make less use of makeStyles and utilize things like:
or optionally, within makeStyles, make use of the theme parameter to inherit styles from theme.js, for example:
I will wait until @nichhk confirms this is the approach we are aiming for. And if there is a need for me to show how we could utilize this in future releases, I would be glad to demonstrate. Thanks for considering my perspective |
@@ -64,30 +65,70 @@ const About = () => { | |||
the expansive amount of data associated with these 311 | |||
requests is available online. The mayor has encouraged | |||
us to create apps with this data, and that's where | |||
this project comes in. | |||
this project comes in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can all instances of
be replaced with a single space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean? non breaking space here is to prevent the orphan text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see. the reason just wasn't clear. but if you find it important to keep those words together this will definitely work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and approved, thanks for considering my feedback!
Fixes #1298
dev
branchAny questions? See the getting started guide