Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1307 be chaching get filtered requests #1359

Merged
merged 2 commits into from
Sep 13, 2022
Merged

1307 be chaching get filtered requests #1359

merged 2 commits into from
Sep 13, 2022

Conversation

nichhk
Copy link
Member

@nichhk nichhk commented Sep 13, 2022

Fixes #1307

Something weird happened and the @cached decorator got lost in git chaos.

Also, add num_requests_past_week to the output of build_cache and do some clean up there.

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@nichhk nichhk requested a review from jekijo September 13, 2022 17:23
jekijo
jekijo approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@jekijo jekijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nichhk
Copy link
Member Author

nichhk commented Sep 13, 2022

Thanks for the review Killen!

@nichhk nichhk merged commit a50bc4d into dev Sep 13, 2022
@nichhk nichhk deleted the 1307-BE-chaching-get-filtered-requests branch September 13, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jekijo jekijo jekijo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement caching for get_filtered_requests
2 participants
@nichhk @jekijo