Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug when checking break condition for get_request_data_csv #1382

Merged

Conversation

nichhk
Copy link
Member

@nichhk nichhk commented Sep 29, 2022

Fixes #1381

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@nichhk nichhk linked an issue Sep 29, 2022 that may be closed by this pull request
1 task
@priyakalyan priyakalyan self-requested a review September 29, 2022 02:57
Copy link
Member

@priyakalyan priyakalyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nich for spotting the bug and taking care of it! Looks good.

@nichhk nichhk merged commit ff44de1 into dev Sep 29, 2022
@nichhk nichhk deleted the 1381-get_request_data_csvpy-is-limited-to-collecting-20k-requests branch September 29, 2022 03:03
@nichhk
Copy link
Member Author

nichhk commented Sep 29, 2022

@ajmachado42, if you sync your codebase, the bug should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_request_data_csv.py is limited to collecting 20k requests
2 participants