#3 v2 header & footer updates #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
@jekijo The third one for you Killen. Please let me know if you have any questions. Thanks again! |
|
@funbunch added you as a reviewer since you have been recently working on these files. Please let me know if you have any questions. Thanks in advance! |
|
Hi @edwinjue Is there a visual change here where we can see a screenshot? |
|
@funbunch good idea! i just updated the first post with screenshots of what the header and footer will look like after merge along with screenshots taken from the figma v2 design. hope it helps |
|
Thanks! Will approve. |
funbunch
approved these changes
Oct 5, 2022
edwinjue
deleted the
1347-thematic-coloring-of-content-pages-3-v2-header-footer-updates
branch
|
@funbunch Thanks, appreciate the quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1347
Screenshots
Header (figma)
Header (#1389)
Footer (figma)
Footer (#1389)
devbranchAny questions? See the getting started guide