Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added search feature to header of FAQs page #1449

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Added search feature to header of FAQs page #1449

merged 3 commits into from
Feb 9, 2023

Conversation

tinazarb
Copy link
Member

@tinazarb tinazarb commented Feb 7, 2023 •
edited
Loading

Fixes #1384

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@edwinjue
Copy link
Member

edwinjue commented Feb 8, 2023

@tinazarb looks good! Thanks for looking into this. Please feel free to add @bryantran04 @hqasmei and myself to the list of reviewers so we'll get notified when there is a PR

@edwinjue edwinjue self-requested a review February 8, 2023 21:34
@edwinjue
Copy link
Member

edwinjue commented Feb 8, 2023

@tinazarb please feel free to click on the Merge pull request button to make these changes available into our codebase

@tinazarb tinazarb merged commit b021cef into dev Feb 9, 2023
@tinazarb tinazarb deleted the 1384-faq-search-header branch February 9, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwinjue edwinjue edwinjue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to add the search feature to header of FAQs page (refer to v2 figma design - FAQs)
2 participants
@tinazarb @edwinjue