-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1708 adjust data cleaning script to prune data points outside of la neighborhood districts #1744
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hi @mru-hub, will review before Sunday 6/9. Thank you! |
Hi @mru-hub, I reviewed the script and did some testing. I think we need a video chat session to discuss further on how to implment this before I can add documentation for my review here. I've send you a slack message, please let me know in Slack when would be a good time to chat. |
…8-adjust-data-cleaning-script-to-prune-data-points-outside-of-la-neighborhood-districts
Hi @mru-hub I pushed the modified script that we discussed to this PR. |
@Skydodle Connected with Johnny and decided to test the code locally by directly passing a filtered Parquet file to the logic instead of using the Hugging Face file. |
Hi @Skydodle I pushed the modified script to this PR. Kindly review. |
…wser, should be deleted for production as this is for testing only
…low to transfofrming to parquet first before filtering
… to parquet as it was already done, updated to using .loc to fix wwarning
…8-adjust-data-cleaning-script-to-prune-data-points-outside-of-la-neighborhood-districts
Update: enabled testing on browser by pointing the file registration to the filtered csv file in public folder. @mru-hub will continue in-depth testing and implement finalized script to integrate with cron job. Thanks. |
Fixes #{issue number here}
main
branchAny questions? See the getting started guide