Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1708 adjust data cleaning script to prune data points outside of la neighborhood districts #1744

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

mru-hub
Copy link
Member

@mru-hub mru-hub commented Jun 3, 2024

Fixes #{issue number here}

  • Up to date with main branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@mru-hub mru-hub requested a review from Skydodle June 3, 2024 04:53
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Skydodle
Copy link
Member

Skydodle commented Jun 4, 2024

Hi @mru-hub, will review before Sunday 6/9. Thank you!

@Skydodle Skydodle mentioned this pull request Jun 15, 2024
4 tasks
@Skydodle
Copy link
Member

Hi @mru-hub, I reviewed the script and did some testing. I think we need a video chat session to discuss further on how to implment this before I can add documentation for my review here. I've send you a slack message, please let me know in Slack when would be a good time to chat.

…8-adjust-data-cleaning-script-to-prune-data-points-outside-of-la-neighborhood-districts
@Skydodle
Copy link
Member

Hi @mru-hub I pushed the modified script that we discussed to this PR.

@mru-hub
Copy link
Member Author

mru-hub commented Jun 19, 2024

@Skydodle Connected with Johnny and decided to test the code locally by directly passing a filtered Parquet file to the logic instead of using the Hugging Face file.

@mru-hub
Copy link
Member Author

mru-hub commented Jun 20, 2024

Hi @Skydodle I pushed the modified script to this PR. Kindly review.

@Skydodle
Copy link
Member

Update: enabled testing on browser by pointing the file registration to the filtered csv file in public folder. @mru-hub will continue in-depth testing and implement finalized script to integrate with cron job. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants