Cleaner Object Addition #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ryanmswan
commented
Feb 1, 2020
ryanmswan
commented
- Added scaffold for cleaner object
- Updated databaseOrm to avoid truncations
- Updated sqlIngest to allow method reuse in cleaner
--DataCleaner object contained in dataCleaner.py inherits methods from DataHandler object --Updated databaseOrm file to accommodate some larger field sizes (street name causing right truncation issue) --Updated DataHandler object ingestData method to take tableName argument in order to allow reuse in DataCleaner. Should now function as a general method to write to database.
ryanmswan
requested review from
sellnat77 and
rgao
and removed request for
sellnat77
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.