Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #166 Dropdown #243

Merged
merged 10 commits into from
Feb 11, 2020
Merged

Issue #166 Dropdown #243

merged 10 commits into from
Feb 11, 2020

Conversation

adamkendis
Copy link
Member

#166

Does NOT fully close the issue. Datepicker will be pushed tomorrow, 2/11 (probably).

Dropdown adhering to Bulma style modifiers. Example:

    <Dropdown
      id="datefilter-dropdown"
      list={[
        { label: 'Last Week', value: 'LAST_WEEK' },
        { label: 'Last Month', value: 'LAST_MONTH' },
        { label: 'Last 6 Months', value: 'LAST_6_MONTHS' },
      ]}
      title="Select Date Range"
      handleClick={someFunc}
      style={{ left: '550px' }}
    />

The thought is that the value of each option will correspond with a switch case in a reducer. See props for additional Bulma modifiers.

Copy link
Member

@brodly brodly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just had a few questions

@brodly brodly merged commit c5652fa into hackforla:dev Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants