Closes #166 - Default and Custom Date Filters (Sidebar Filter) #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
brodly
reviewed
Feb 15, 2020
brodly
reviewed
Feb 15, 2020
brodly
reviewed
Feb 15, 2020
brodly
reviewed
Feb 15, 2020
brodly
reviewed
Feb 15, 2020
brodly
reviewed
Feb 15, 2020
brodly
suggested changes
Feb 15, 2020
brodly
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #166
Rundown of components and changes included in this PR:
New Components:
Default date selector nested in the left slider
<Menu />.A background overlay and empty container for modal content. This component will be nested in
<Body />.Custom date range picker. This component is the content rendered in
<Modal />Not currently in use as it is not 100% working.
Planning on fixing this up after we hit MVP. It's a visual enhancement, not a functionality enhancement.
Changes to existing components:
Renamed
handleClickprop toonClick. Seemed more intuitive where the Dropdown is actually used.Added an extremely high z-index to both components to prevent
<Modal />from stacking on top of them when active.Notes:
I haven't added the DateSelector to Menu yet. I don't know if it needs refactoring or if I can just drop the DateSelector in somewhere.
Still need to add the circle info icon to DateSelector once
<Icon />is done.The custom date range picker differs from the mockup. It was easier to implement with individual calendar popups for each input.
Some styles will be tweaked after Basic Sass setup. Issue Basic Sass setup #254
What date format should we be sending to the back end?
Everything is hooked up to Redux.
Screenshots
DateSelector
Modal + DateRangePicker