Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

157 sidebar together #309

Merged
merged 56 commits into from
Mar 1, 2020
Merged

157 sidebar together #309

merged 56 commits into from
Mar 1, 2020

Conversation

brodly
Copy link
Member

@brodly brodly commented Feb 27, 2020 •
edited
Loading

  • Fixed menu sliding bug
  • Updated map starting position
  • Updated map pins to adhere to backend data shape
  • Added styling to Icon Component
  • Fixed off-centered checkbox in NC Selector
  • Added submit button to call data from backend
  • Added redux saga
  • Created temp error display for debugging

brodly added 30 commits February 17, 2020 15:34
@brodly
Added redux saga
ce741ca
@brodly
Added redux saga
d57a0ef
@brodly
Added time stamp of last updated data
9e37d68
@brodly
Added redux saga. Added axios request for get data
8b708fc
@brodly
Added get data submit button
d10fe18
@brodly
added icon style. disabled jsx a11y
cb966f5
@brodly
Updated chevron to caret for menu button
05831ad
@brodly
Added info helper icon
2d4c64f
@brodly
Fixed scrollbar showing bug
785d951
@brodly
Removed unused div
f6df248
@brodly
Added css style overwrite file
5012d81
@brodly
updated map height to scale properly with push sidebar effect
b63d470
@brodly
Added proper location of page wrap for menu
586bb6e
@brodly
updated menu to push
c8f1936
@brodly
Created
0f55981
@brodly
Menu slides
3273c30
@brodly
checkboxes are small
aa469e0
@brodly
testing backend calls
742b851
@brodly
testing backend calls
17ecf55
@brodly
Merge branch 'dev' of https://github.com/hackforla/311-data into 157_…
8d2d81c 
…sidebar_together
@brodly
Added error display for testing
c0fa4b4
@brodly
testing
e2a4056
@brodly
Merge branch 'dev' of https://github.com/hackforla/311-data into 157_…
267ed45 
…sidebar_together
@brodly
Merge branch 'dev' of https://github.com/hackforla/311-data into 157_…
342dd89 
…sidebar_together
@brodly
Merge branch 'dev' of https://github.com/hackforla/311-data into 157_…
66a236e 
…sidebar_together
@brodly
Merge branch 'dev' of https://github.com/hackforla/311-data into 157_…
7588229 
…sidebar_together
@brodly
Added submit button
2a684f1
@brodly
Added checkbox style fix for uneven checkboxes
24d17b9
@brodly
Created submit component
31da7bd
@brodly
testing backend calls
07faa3e
sellnat77
sellnat77 suggested changes Feb 27, 2020
View reviewed changes
src/redux/rootSaga.js Outdated Show resolved Hide resolved
jmensch1
jmensch1 reviewed Feb 27, 2020
View reviewed changes
Copy link
Contributor

@jmensch1 jmensch1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, is src/styles/styles.css doing anything? I didn't see it imported anywhere.

adamkendis
adamkendis reviewed Feb 28, 2020
View reviewed changes
Copy link
Member

@adamkendis adamkendis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment re lastUpdated.

src/redux/reducers/data.js Outdated Show resolved Hide resolved
@brodly
Copy link
Member Author

brodly commented Mar 1, 2020

hey, is src/styles/styles.css doing anything? I didn't see it imported anywhere.

I believe it is a leftover from me attempting to fix the funky sidebar issue.

brodly added 15 commits March 1, 2020 11:18
@brodly
Store db URL in env file. Send proper req body to server
13c3e03
@brodly
Merge branch '157_sidebar_together' of https://github.com/hackforla/3…
3ec69de 
…11-data into 157_sidebar_together
@brodly
Merge branch 'dev' of https://github.com/hackforla/310-data into 157_…
19bca19 
…sidebar_together
@brodly
Merge branch 'dev' of https://github.com/hackforla/311-data into 157_…
8091943 
…sidebar_together
@brodly
Removed settings object, placed in eslintrc
f7ee4be
@brodly
Removed unused comments
dc0a064
@brodly
Removed unused comments
0e7f66f
@brodly
Updated date to accept unixtime from server
5eecbdc
@brodly
Pass full data response to store
fab880c
@brodly
Update store with server lastUpdated response
b2c573e
@brodly
key off srnumber for pins
a5eba41
@brodly
Fixed alias import linting error
5eb44ef
@brodly
Added default props
376e91c
@brodly
Refined rules on arrow parens
d148437
@brodly
properly enforcing linting
3824925
@sellnat77 sellnat77 mentioned this pull request Mar 1, 2020
Closed
@brodly
Copy link
Member Author

brodly commented Mar 1, 2020

This became a larger PR as I fixed a bug where our linter wasnt working properly and had to resolve a lot of linting issues

@brodly brodly merged commit 455e75d into dev Mar 1, 2020
@brodly brodly deleted the 157_sidebar_together branch March 1, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmensch1 jmensch1 jmensch1 left review comments

@adamkendis adamkendis adamkendis left review comments

@sellnat77 sellnat77 sellnat77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brodly @sellnat77 @jmensch1 @adamkendis