Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live data for charts #413

Merged
merged 9 commits into from
Mar 14, 2020
Merged

live data for charts #413

merged 9 commits into from
Mar 14, 2020

Conversation

jmensch1
Copy link
Contributor

@jmensch1 jmensch1 commented Mar 11, 2020

This connects the pie charts and the NumberOfRequests component to real data, and stubs out the data connection for the other charts as well (Time To Close, Frequency, Total Requests).

To lay the groundwork for that, I moved the filters -- startDate, endDate, councils, requestTypes -- into their own reducer so that the data reducer would be cleaner. The data reducer now holds data for the map and all of the charts, plus error, lastUpdated, and isLoading.

This request also includes some minor fixes to the Menu, Footer, and Criteria components.

Also, in order to make local dev easier, the api calls now assume that the DB_URL environment variable includes the scheme. So in the .env file:

DB_URL=https://hackforla-311-data.herokuapp.com

If you need to switch to the local database, you can just change that to:

DB_URL=http://localhost:5000

@jmensch1 jmensch1 requested review from adamkendis and brodly March 11, 2020 15:30
src/redux/rootSaga.js Outdated Show resolved Hide resolved
Copy link
Member

@brodly brodly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, i left a comment re: redux saga/async calls

@sellnat77
Copy link
Member

When @brodly GIves the 👍 ill update the github secret to include the https in the url

@brodly brodly merged commit 555ea08 into dev Mar 14, 2020
@brodly brodly deleted the FRONT-LiveDataForCharts branch March 14, 2020 20:46
@brodly
Copy link
Member

brodly commented Mar 14, 2020

When @brodly GIves the 👍 ill update the github secret to include the https in the url

Merged. Go ahead and update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Role: Frontend React front end work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Added] Box and Whiskers Data Visualization (Time to Close)
4 participants