-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
live data for charts #413
Merged
Merged
live data for charts #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brodly
reviewed
Mar 12, 2020
brodly
suggested changes
Mar 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, i left a comment re: redux saga/async calls
3 tasks
3 tasks
When @brodly GIves the 👍 ill update the github secret to include the https in the url |
brodly
approved these changes
Mar 14, 2020
Merged. Go ahead and update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This connects the pie charts and the NumberOfRequests component to real data, and stubs out the data connection for the other charts as well (Time To Close, Frequency, Total Requests).
To lay the groundwork for that, I moved the filters -- startDate, endDate, councils, requestTypes -- into their own reducer so that the data reducer would be cleaner. The data reducer now holds data for the map and all of the charts, plus error, lastUpdated, and isLoading.
This request also includes some minor fixes to the Menu, Footer, and Criteria components.
Also, in order to make local dev easier, the api calls now assume that the DB_URL environment variable includes the scheme. So in the .
env
file:DB_URL=https://hackforla-311-data.herokuapp.com
If you need to switch to the local database, you can just change that to:
DB_URL=http://localhost:5000