Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added data error modal. Fix store not saving error #426

Merged
merged 1 commit into from
Mar 14, 2020
Merged

Added data error modal. Fix store not saving error #426

merged 1 commit into from
Mar 14, 2020

Conversation

brodly
Copy link
Member

@brodly brodly commented Mar 14, 2020

Fixes #264

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@brodly brodly requested review from jmensch1 and adamkendis March 14, 2020 23:37
jmensch1
jmensch1 approved these changes Mar 14, 2020
View reviewed changes
Copy link
Contributor

@jmensch1 jmensch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@brodly brodly mentioned this pull request Mar 14, 2020
Closed
3 tasks
@brodly brodly merged commit 5b4168d into dev Mar 14, 2020
@brodly brodly deleted the 264_error_handling branch March 14, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmensch1 jmensch1 jmensch1 approved these changes

@adamkendis adamkendis Awaiting requested review from adamkendis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display Errors when Loading/Displaying Data fails
2 participants
@brodly @jmensch1