Front - grouping NC's / accessibility #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmensch1
added
the
Do Not Merge
jmensch1
removed
the
Do Not Merge
|
Just updated the regions, this is ready now |
adamkendis
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the new design of the NC selector where the NC's are grouped by region.
It also fixes about 100 accessibility errors that were coming from the NC selector.
The core of the PR is a new MultiSelect component, with a built-in search bar and the option to group the select items together. This separates the logic of a multi-select form from the details of our business logic. The component is also fully navigable using the tab and enter keys.
The MultiSelect is used in both the NC selector and the CC selector, which eliminates the duplication that was happening between the NC selector in the main filters and the NC/CC selectors in the comparison modal.
devbranch