Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickle base fix #642

Merged
merged 2 commits into from
May 21, 2020
Merged

Pickle base fix #642

merged 2 commits into from
May 21, 2020

Conversation

jmensch1
Copy link
Contributor

@jmensch1 jmensch1 commented May 21, 2020

So in the last round I was trying to populate the picklebase before starting the server. It took longer than 60 seconds, so the server failed with an error:

Error R10 (Boot timeout) -> Web process failed to bind to $PORT within 60 seconds of launch

In this PR the server is started immediately, and the picklebase is populated in a separate process. A file called 'ready' is created when process finishes, which informs the Sanic workers that they can query the picklebase instead of the database.

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@jmensch1 jmensch1 requested a review from adamkendis May 21, 2020 22:45
@adamkendis adamkendis merged commit 3f6ddee into dev May 21, 2020
@adamkendis adamkendis deleted the PickleBaseFix branch May 21, 2020 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants